Add support for FTS5#17
Merged
rkistner merged 1 commit intojourneyapps:masterfrom Mar 27, 2019
Merged
Conversation
drahnr
added a commit
to drahnr/signal-desktop-rpm
that referenced
this pull request
Feb 27, 2019
Contributor
Author
grebe
added a commit
to grebe/Signal-Desktop
that referenced
this pull request
Feb 3, 2020
Signal is currently using a forked version of node-sqlcipher. I'm not entirely sure as to all the motivations for forking, but it seems that one reason may have been because upstream didn't support FTS5. This reason is no longer relevant because of this PR [^1], which adds FTS5 support upstream. Another reason for the forked version of node-sqlcipher may be to bundle libcrypto. This is causing problems with many Linux users, especially those who are not using Ubuntu [^2][^3]. It seems to me that statically linking is not generally considered to be a best practice on Linux. The upstream project's README [^4] seems to have a sensible policy: bundling OpenSSL on Windows and OS X platforms and dynamically linking to the system's library on Linux platforms. This PR moves away from the forked node-sqlcipher and returns back to upstream. This seems to fix OpenSSL problems on non-Ubuntu Linux distributions. [^1]: journeyapps/node-sqlcipher#17 [^2]: signalapp#2634 [^3]: signalapp#2662 [^4]: https://github.com/journeyapps/node-sqlcipher#openssl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for FTS5, and a unit test to check if it actually works.
Cheers,
Ferdinand